Open
Conversation
* added delete_snapshot * updated _volume_not_present
* minor fixed in snapshot create/delete
There was a problem hiding this comment.
could this log message be in english ?
|
The features added by this pull request are interesting, could it be merged ? (pending modifications on log messages) |
Translating log message from portuguese to english, as requested.
Author
|
All right, log messages already translated. |
|
@tparker00 Are you still maintaining this code? |
|
@tparker00 @mariocar @arthurlogilab I might be interested in taking over maintenance of this, if I can get help. I haven't coded Python in years and years (and I wasn't brilliant at it when I did :) but this is a core "business requirement" for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added these two funcionalities to your code.
Best regards.